PacketFence
Bug Tracking System

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001470PacketFencei18npublic2012-06-14 19:172012-06-18 08:31
Reporterpb1dft 
Assigned Toobilodeau 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusfeedbackResolutionopen 
PlatformOSOS Version
Product Version3.4.0 
Target VersionFixed in Version 
Summary0001470: error in guest.pm
Descriptionon line 271 i18n($_) should be i18n()

Otherwise translations for the field names wil not work
TagsNo tags attached.
fixed in git revision
fixed in mtn revision
Attached Files

- Relationships

-  Notes
(0002802)
obilodeau (reporter)
2012-06-15 15:17

line 271? the closest i18n() call in pf::web::guest is 290 and is:
return ( $FALSE, $GUEST::ERROR_MISSING_MANDATORY_FIELDS, [ join(", ", map { i18n($_) } @missing_fields) 
] );


is this you are talking about?

If so, I don't understand the mistake. map assigns each array member into $_ and we pass it through i18n which returns it translated and it's joined afterwards.

Pretty sure that if you remove $_ nothing will happen. Can you elaborate?

Thanks
(0002808)
pb1dft (reporter)
2012-06-17 22:05

in my case when i removed $_ it translated as it should with it would not translate. I can retry as the language file i'm using is one big mess and i'm halfway translating it again. In other word i started from scratch to make the text more sensible. I would have to test it again when i'm finished.
(0002809)
obilodeau (reporter)
2012-06-18 08:31

Will need to attempt to reproduce in lab. Before then if you can try again it will be appreciated.

- Issue History
Date Modified Username Field Change
2012-06-14 19:17 pb1dft New Issue
2012-06-15 15:17 obilodeau Note Added: 0002802
2012-06-15 15:17 obilodeau Status new => assigned
2012-06-15 15:17 obilodeau Assigned To => obilodeau
2012-06-17 22:05 pb1dft Note Added: 0002808
2012-06-18 08:31 obilodeau Note Added: 0002809
2012-06-18 08:31 obilodeau Reproducibility always => have not tried
2012-06-18 08:31 obilodeau Status assigned => feedback
2012-06-18 08:31 obilodeau Target Version => +1


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker