PacketFence - BTS - PacketFence
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000960PacketFencecorepublic2010-04-16 14:072015-02-13 15:26
Reporterobilodeau 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionopen 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
fixed in git revision
fixed in mtn revision
Summary0000960: pfcmd changes the config files ownership when called at command line
DescriptionWhen I edit a switch using:
./pfcmd 'switchconfig edit 1.2.3.4 vlans="2,3"'

pfcmd changes switches.conf ownership from pf:pf to root:root.

Same behaviour with floating_network_devices.conf
Steps To Reproduce
Additional InformationIf this bug is fixed, re-enable the test in lib/pfcmd/checkup.pm to test file configuration ownership.
TagsNo tags attached.
Relationships
has duplicate 0001345closed  Saving from the GUI changes the permissions of the files on the filesystem 
has duplicate 0001407resolved fgaudreault Switches.conf ownership changes to root after update from GUI. 
related to 0001544closed  SoH configuration page fails to load because of config file permissions 
child of 0000963closed obilodeau Challenge the assumption that pfcmd must run as root setuid 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-04-16 14:07rbalzardNew Issue
2010-05-04 14:42obilodeauNote Added: 0001529
2010-05-04 14:50obilodeauRelationship addedchild of 0000963
2010-05-04 14:52obilodeauNote Added: 0001530
2010-05-04 14:52obilodeauCategory1.9.x => 1.10.x
2010-05-04 14:52obilodeauTarget Version1.9.0 =>
2010-11-19 14:28obilodeauCategory1.10.x => 2.x
2010-11-19 14:50obilodeauCategory2.x => core
2011-01-18 11:41obilodeauTarget Version => 2.1.0
2011-03-03 15:15obilodeauTarget Version2.1.0 => +1
2011-03-03 15:18obilodeauTarget Version+1 => +2
2012-01-11 09:06obilodeauRelationship addedhas duplicate 0001345
2012-01-11 09:15obilodeauStatusnew => assigned
2012-01-11 09:15obilodeauAssigned To => obilodeau
2012-01-11 09:33obilodeauNote Added: 0002532
2012-01-11 09:34obilodeauNote Added: 0002533
2012-01-11 09:34obilodeauReporterrbalzard => 94jaccha95107
2012-01-11 09:34obilodeauTarget Version+2 =>
2012-01-11 09:35obilodeauReporter94jaccha95107 => obilodeau
2012-01-11 09:37obilodeauAdditional Information Updated
2012-01-11 09:38obilodeauNote Added: 0002534
2012-04-11 22:17obilodeauRelationship addedduplicate of 0001407
2012-04-11 22:17obilodeauRelationship deleted0001407
2012-04-11 22:18obilodeauRelationship addedhas duplicate 0001407
2012-09-11 09:39obilodeauRelationship addedrelated to 0001544
2012-10-19 14:01fgaudreaultAssigned Toobilodeau =>
2012-10-19 14:01fgaudreaultTarget Version => long-term
2015-02-13 15:26lmunroNote Added: 0003693
2015-02-13 15:26lmunroStatusassigned => closed

Notes
(0001529)
obilodeau   
2010-05-04 14:42   
could be normal, right now bin/pfcmd is meant to be a setuid root command
(0001530)
obilodeau   
2010-05-04 14:52   
important if we want to move out of a setuid pfcmd (setting child of bug 0000963).

Targeting for later.
(0002532)
obilodeau   
2012-01-11 09:33   
Using ->ReWriteConfig instead of ->WriteConfig in pfcmd could've fixed it however I just read that both don't perform locking or transaction control so it would be worse if we read an incompletely written file then modify it and write it back.
(0002533)
obilodeau   
2012-01-11 09:34   
removing target. only important to fix if we implement 0000963
(0002534)
obilodeau   
2012-01-11 09:38   
Disabled verification of the configuration file since pfcmd is setuid and will probably stay that way a little while.

If this bug is fixed, re-enable the test in lib/pfcmd/checkup.pm to test file configuration ownership.
(0003693)
lmunro   
2015-02-13 15:26   
Old issues.
Most are not relevant to PF 4 and up.

Let's reopen the ones that matter when we move to github.