PacketFence - BTS - PacketFence |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0000910 | PacketFence | performance | public | 2010-02-09 15:07 | 2011-01-26 15:38 |
|
| Reporter | obilodeau | |
| Assigned To | obilodeau | |
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | | OS Version | |
| Product Version | 1.8.7 | |
| Target Version | 1.9.0 | Fixed in Version | 1.9.0 | |
| fixed in git revision | |
| fixed in mtn revision | 17b374bae1c3fad156b6a3006369c0ca4bc9a39c |
|
| Summary | 0000910: inefficient vlan_determine_for_node() and custom_getCorrectVlan() instantiate SwitchFactory unnecessarily |
| Description | Each time we create a new switchFactory the conf/switches.conf file is parsed and it's avoidable work. Especially during high load periods or when we will use these methods for each radius request.
Fix that by passing around the higher level switch object instead of reconstructing the object from the factory each time. |
| Steps To Reproduce | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2010-02-09 15:07 | obilodeau | New Issue | |
| 2010-02-09 15:07 | obilodeau | Status | new => assigned |
| 2010-02-09 15:07 | obilodeau | Assigned To | => obilodeau |
| 2010-02-09 16:03 | obilodeau | Note Added: 0001468 | |
| 2010-02-09 16:03 | obilodeau | Status | assigned => resolved |
| 2010-02-09 16:03 | obilodeau | Fixed in Version | => 1.8.8 |
| 2010-02-09 16:03 | obilodeau | Resolution | open => fixed |
| 2010-02-09 16:03 | obilodeau | mtn revision | => 17b374bae1c3fad156b6a3006369c0ca4bc9a39c |
| 2010-02-10 11:23 | obilodeau | Category | 1.8.7 => performance |
| 2010-04-29 13:38 | obilodeau | Fixed in Version | 1.8.8 => 1.9.0 |
| 2010-04-29 13:39 | obilodeau | Target Version | 1.8.8 => 1.9.0 |
| 2011-01-26 15:38 | obilodeau | Status | resolved => closed |