PacketFence - BTS - PacketFence
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000840PacketFenceerror-handlingpublic2009-11-06 15:522015-02-13 15:26
Reporterobilodeau 
Assigned Toobilodeau 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionopen 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
fixed in git revision
fixed in mtn revision
Summary0000840: pfcmd node edit (web node edit) fails silently
Descriptionreproduced in the lab with:
bin/pfcmd node edit 00:12:f0:13:32:ba pid=guest,status="reg"

doesn't work, no error message
Steps To Reproduce
Additional Information
Tagsusability
Relationships
has duplicate 0000917closed obilodeau node add fails on key constraint and they are not validated beforehand 
has duplicate 0001310resolved fgaudreault adding a node before adding a person causes key constraint failed without proper error message in the UI 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-11-06 15:52obilodeauNew Issue
2009-11-06 15:52obilodeauStatusnew => assigned
2009-11-06 15:52obilodeauAssigned To => obilodeau
2009-11-06 15:56obilodeauNote Added: 0001388
2009-11-06 15:57obilodeauNote Added: 0001389
2010-03-01 13:28obilodeauCategory1.8.5 => error-handling
2010-07-23 13:02obilodeauTag Attached: usability
2011-01-18 11:53obilodeauTarget Version => 2.0.1
2011-01-26 15:30obilodeauTarget Version2.0.1 => 2.0.2
2011-03-03 15:19obilodeauTarget Version2.0.2 => +1
2011-10-17 10:01obilodeauRelationship addedhas duplicate 0000917
2011-10-17 10:01obilodeauRelationship addedhas duplicate 0001310
2015-02-13 15:26lmunroNote Added: 0003725
2015-02-13 15:26lmunroStatusassigned => closed

Notes
(0001388)
obilodeau   
2009-11-06 15:56   
here's the low-level problem:

mysql> update node set pid='guest', status='reg' where mac='00:12:f0:13:32:ba';
ERROR 1452 (23000): Cannot add or update a child row: a foreign key constraint fails (`pf/node`, CONSTRAINT `0_57` FOREIGN KEY (`pid`) REFERENCES `person` (`pid`) ON DELETE CASCADE ON UPDATE CASCADE)

we need to atleast deal with this error in the code, right now everything silently fails
(0001389)
obilodeau   
2009-11-06 15:57   
heck even a dropdown box for pid should be offered in the node edit screen instead of a text input if this is a real constraint
(0003725)
lmunro   
2015-02-13 15:26   
Old issues.
Most are not relevant to PF 4 and up.

Let's reopen the ones that matter when we move to github.