PacketFence - BTS - PacketFence
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000833PacketFenceupstreampublic2009-10-30 15:172011-01-26 15:38
Reporterobilodeau 
Assigned Toobilodeau 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version1.9.0 
fixed in git revision
fixed in mtn revisionf910994e452cb1a6a14b41da81d457df70a92294
Summary0000833: Parse::RecDescent 1.962 regression
DescriptionLatest version of Parse::RecDescent doesn't work with packetfence..

Error message is: Can't coerce GLOB to string in or at /usr/local/pf/bin/pfcmd line 1794.

It turns out that a newer Parse::RecDescent generate a pfcmd_pregrammar.pm that causes problems when pfcmd is called form the admin interface. Also on startup you can see the coerce glob error.

http://search.cpan.org/dist/Parse-RecDescent/ [^]

Known buggy:
perl-Parse-RecDescent-1.962.2-1.el5.rf

Known to work:
perl-Parse-RecDescent-1.94-1.el5.rf

Tasks:
- upgrade lab to 1.962
- run packetfence, check for error
- regenerate pfcmd_grammar
- re-run packetfence, did that fix the error?
- if not, find root cause and report upstream if needed
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
parent of 0000806closed obilodeau Parse::RecDescent regression causing errors in admin interface 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-10-30 15:17obilodeauNew Issue
2009-10-30 15:17obilodeauRelationship addedparent of 0000806
2009-10-30 15:17obilodeauStatusnew => assigned
2009-10-30 15:17obilodeauAssigned To => obilodeau
2010-05-05 12:44obilodeauCategoryfuture => upstream
2010-05-06 12:55obilodeaumtn revision => 7beb12ad733d0a113e304aa4bdd1d6a4ce70ef58
2010-05-06 12:55obilodeauNote Added: 0001562
2010-05-06 12:55obilodeauStatusassigned => resolved
2010-05-06 12:55obilodeauFixed in Version => 1.9.0
2010-05-06 12:55obilodeauResolutionopen => unable to reproduce
2010-05-17 17:44obilodeauNote Added: 0001566
2010-05-17 17:44obilodeauStatusresolved => feedback
2010-05-17 17:44obilodeauResolutionunable to reproduce => reopened
2010-05-17 18:02obilodeaumtn revision7beb12ad733d0a113e304aa4bdd1d6a4ce70ef58 => f910994e452cb1a6a14b41da81d457df70a92294
2010-05-17 18:02obilodeauNote Added: 0001567
2010-05-17 18:02obilodeauStatusfeedback => resolved
2010-05-17 18:02obilodeauResolutionreopened => fixed
2010-05-25 17:11obilodeauNote Added: 0001569
2011-01-26 15:38obilodeauStatusresolved => closed

Notes
(0001562)
obilodeau   
2010-05-06 12:55   
I was unable to reproduce so I removed the pinned version.
(0001566)
obilodeau   
2010-05-17 17:44   
I got hit by this again after all.

It was reproducible when bin/pfcmd was called from the web in cgi-bin (as user pf).

ex: /usr/local/pf/bin/pfcmd 'manage register aa:bb:cc:dd:ee:ff "test" pid="1",user_agent="Mozilla 5.0 Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2.3 Gecko 20100401 Firefox 3.6.3",vlan="1"'

A really nasty bitch to find, not so much to fix. Upstream behavior did change but I don't really get what's up with "Can't coerce GLOB to string" so I tried using the command variable and calling the method using &{$..} and it works so it's good enough for me.
(0001567)
obilodeau   
2010-05-17 18:02   
Hopefully fixed for good now in mtn revno: f910994e452cb1a6a14b41da81d457df70a92294

Removal of pinned dep in RPM spec in mtn revno: 7beb12ad733d0a113e304aa4bdd1d6a4ce70ef58
(0001569)
obilodeau   
2010-05-25 17:11   
pushed another change on top of fix in revno 87d1afe8367be3c58d53ebcf90e49fd037297cc6

removed symbolic references in favor of hard ones