PacketFence - BTS - PacketFence
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000749PacketFencecorepublic2009-07-16 16:332012-10-26 16:05
Reporterobilodeau 
Assigned Tofgaudreault 
PriorityhighSeverityminorReproducibilityhave not tried
StatusassignedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version3.6.1Fixed in Version 
fixed in git revisionb78251653ec9f535f9e1cf3fa898b75350357d5e
fixed in mtn revision
Summary0000749: Violation load does not validate if 2 violations have the same ID
DescriptionThere should be a control, when loading violations, that make sure that 2 violations do not have the same ID in violations.conf.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0000992closed fgaudreault validation should be performed on trigger ranges 
has duplicate 0000773resolved obilodeau need better error message when two violations have the same id 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-07-16 16:33rbalzardNew Issue
2009-08-19 15:52obilodeauRelationship addedhas duplicate 0000773
2009-08-19 15:55obilodeauStatusnew => assigned
2009-08-19 15:55obilodeauAssigned To => obilodeau
2011-01-18 12:02obilodeauTarget Version => 2.1.0
2011-03-03 15:15obilodeauTarget Version2.1.0 => +1
2011-03-03 15:19obilodeauTarget Version+1 => +2
2011-04-04 11:54fgaudreaultAssigned Toobilodeau => fgaudreault
2011-04-04 11:59fgaudreaultReporterrbalzard => obilodeau
2011-04-04 14:24fgaudreaultRelationship addedrelated to 0000992
2012-02-29 10:58obilodeauCategoryfuture => core
2012-08-06 12:18fgaudreaultgit revision => b78251653ec9f535f9e1cf3fa898b75350357d5e
2012-08-06 12:18fgaudreaultNote Added: 0002870
2012-08-06 12:18fgaudreaultStatusassigned => resolved
2012-08-06 12:18fgaudreaultResolutionopen => fixed
2012-08-07 12:13obilodeauNote Added: 0002902
2012-08-07 12:13obilodeauPrioritynormal => high
2012-08-07 12:13obilodeauStatusresolved => assigned
2012-08-07 12:13obilodeauTarget Version+2 => +1
2012-10-19 13:51fgaudreaultNote Added: 0003178
2012-10-26 16:05fgaudreaultTarget Versiongeneral => 3.6.1

Notes
(0002870)
fgaudreault   
2012-08-06 12:18   
In Devel!!
(0002902)
obilodeau   
2012-08-07 12:13   
I moved this out of devel into a separate branch. Identical copy / pasted code is prone to insidious bugs in the face of future changes (forgetting the old location). It should be extracted out in a method that shares the same code.

Branch created: https://github.com/inverse-inc/packetfence/tree/fix/749-check-duplicate-violation-id [^]

I'll refactor the code if you don't have the time for it.
(0003178)
fgaudreault   
2012-10-19 13:51   
Code need refactoring.