PacketFence - BTS - PacketFence |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0001507 | PacketFence | | public | 2012-08-08 10:46 | 2012-09-06 10:57 |
|
| Reporter | obilodeau | |
| Assigned To | obilodeau | |
| Priority | high | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | | OS Version | |
| Product Version | 3.5.0 | |
| Target Version | 3.5.1 | Fixed in Version | 3.5.1 | |
| fixed in git revision | 6a7cdad |
| fixed in mtn revision | |
|
| Summary | 0001507: Web extension point (pf::web::custom) no longer works in 3.5.0 |
| Description | The newly added Portal Profiles feature introduced the problem. The order of importation causes pf::web::custom to be compiled before pf::web. Making the latter a refused redefinition of the first.
Because of a readily available and simple work-around, we will fix the issue in a clean way: getting rid of Portal::Session's dependency on the pf::web code. To do so there's only one task remaining: killing the last caller on get_client_ip in pf::web and moving that code in Portal::Session. 0001485 describe this de-coupling effort in more details. |
| Steps To Reproduce | |
| Additional Information | Easy workaround available:
Comment the line 'use pf::web::custom' in lib/pf/Portal/Session.pm
If you customized get_client_ip, you'll need to copy your customization in pf::web since it won't be in effect anymore. |
| Tags | No tags attached. |
| Relationships | | related to | 0001485 | resolved | | pf::web::guest / admin guest creation need some kind of separation |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2012-08-08 10:46 | obilodeau | New Issue | |
| 2012-08-08 10:49 | obilodeau | Relationship added | related to 0001485 |
| 2012-08-08 10:50 | obilodeau | Description Updated | |
| 2012-08-08 10:50 | obilodeau | Additional Information Updated | |
| 2012-08-27 11:35 | obilodeau | Status | new => assigned |
| 2012-08-27 11:35 | obilodeau | Assigned To | => obilodeau |
| 2012-08-27 13:34 | obilodeau | git revision | => 6a7cdad |
| 2012-08-27 13:34 | obilodeau | Note Added: 0002971 | |
| 2012-08-27 13:34 | obilodeau | Status | assigned => resolved |
| 2012-08-27 13:34 | obilodeau | Fixed in Version | => +1 |
| 2012-08-27 13:34 | obilodeau | Resolution | open => fixed |
| 2012-09-06 10:56 | obilodeau | Target Version | +1 => 3.5.1 |
| 2012-09-06 10:56 | obilodeau | Fixed in Version | +1 => 3.5.1 |
| 2012-09-06 10:57 | obilodeau | Note Added: 0003018 | |
| 2012-09-06 10:57 | obilodeau | Status | resolved => closed |