PacketFence - BTS - PacketFence
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001485PacketFencecorepublic2012-07-10 15:552012-10-19 13:46
Reporterdwuelfrath 
Assigned To 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusresolvedResolutionopen 
PlatformOSOS Version
Product Versiondevel 
Target Version3.6.0Fixed in Versiondevel 
fixed in git revision
fixed in mtn revision
Summary0001485: pf::web::guest / admin guest creation need some kind of separation
DescriptionIt's seems like there's code "reutilization" but in a strange way...
guest creation (preregistered) should be "admin stuff" and for the moment there's a strong link with portal methods
Steps To Reproduce
Additional Informationnew portal profiles uses a portalSession object which is not meant to be used on the admin side. Since some methods in the guests preregistration workflow are the same as the ones used for different captive portal pages generation, there's some kind of conflict

There should also have a real distinction between these concepts (templates, cgi, generation methods)
TagsNo tags attached.
Relationships
related to 0001507closed obilodeau Web extension point (pf::web::custom) no longer works in 3.5.0 
related to 0001518closed obilodeau guest management login doesn't work 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-07-10 15:55dwuelfrathNew Issue
2012-07-11 16:22dwuelfrathNote Added: 0002827
2012-08-08 10:49obilodeauRelationship addedrelated to 0001507
2012-08-28 15:01obilodeauStatusnew => assigned
2012-08-28 15:01obilodeauAssigned To => obilodeau
2012-08-28 15:02obilodeauNote Added: 0002983
2012-08-29 16:00obilodeauRelationship addedrelated to 0001518
2012-08-29 16:13obilodeauNote Added: 0002990
2012-09-12 14:01obilodeauNote Added: 0003055
2012-10-19 13:46fgaudreaultAssigned Toobilodeau =>
2012-10-19 13:46fgaudreaultStatusassigned => resolved
2012-10-19 13:46fgaudreaultFixed in Version => devel
2012-10-19 13:46fgaudreaultTarget Version => 3.6.0

Notes
(0002827)
dwuelfrath   
2012-07-11 16:22   
- should a real distinction between admin web and portal web... admin should include guest_admin_reg
- different templates used for guest self registration and guest admin registration (put these templates elsewhere...)
- pf::web::generate_error_page <-> pf::web::generate_admin_error_page

ONCE DONE:
- inline get_client_ip in new pf::Portal::Session stuff
- standardize the way of calling templates, variables VS non-variables, ..
(0002983)
obilodeau   
2012-08-28 15:02   
work started in branch: fix/1485-web-guest-vs-admin-separation

See: https://github.com/inverse-inc/packetfence/commits/fix/1485-web-guest-vs-admin-separation [^]
(0002990)
obilodeau   
2012-08-29 16:13   
I'm done with this here. See the changes:
https://github.com/inverse-inc/packetfence/compare/fix/apache-acl-generation-for-guests...fix/1485-web-guest-vs-admin-separation [^]

Once the pull request for fix/apache-acl-generation-for-guests will be merged, I'm going to open a pull request for fix/1485-web-guest-vs-admin-separation.

Doing so because the latter branch was derived from the former branch.
(0003055)
obilodeau   
2012-09-12 14:01   
pull request opened: https://github.com/inverse-inc/packetfence/pull/60 [^]