PacketFence - BTS - PacketFence
View Issue Details
0001484PacketFencerefactoringpublic2012-07-10 15:512012-09-06 10:57
dwuelfrath 
obilodeau 
hightrivialN/A
closedfixed 
3.5.0 
3.5.13.5.1 
2dc22a1
0001484: post_uri on pf::web::guest::generate_selfregistration_page
Why we require the post_uri to be passed as parameter since this method is called only twice, from the same .cgi, with a value of a "private" variable...

either remove this parameter or set a default one.
from portal profiles work
No tags attached.
Issue History
2012-07-10 15:51dwuelfrathNew Issue
2012-08-06 16:33obilodeauNote Added: 0002883
2012-08-06 16:34obilodeauPrioritynormal => high
2012-08-06 16:34obilodeauSeverityfeature => trivial
2012-08-06 16:34obilodeauStatusnew => acknowledged
2012-08-06 16:34obilodeauCategorycore => refactoring
2012-08-06 16:34obilodeauProduct Versiondevel => 3.5.0
2012-08-06 16:34obilodeauTarget Version => +1
2012-08-15 10:33obilodeauStatusacknowledged => assigned
2012-08-15 10:33obilodeauAssigned To => obilodeau
2012-08-15 10:33obilodeauNote Added: 0002933
2012-08-15 11:11obilodeaugit revision => 2dc22a1
2012-08-15 11:11obilodeauNote Added: 0002934
2012-08-15 11:11obilodeauStatusassigned => resolved
2012-08-15 11:11obilodeauFixed in Version => +1
2012-08-15 11:11obilodeauResolutionopen => fixed
2012-09-06 10:56obilodeauTarget Version+1 => 3.5.1
2012-09-06 10:56obilodeauFixed in Version+1 => 3.5.1
2012-09-06 10:57obilodeauNote Added: 0003019
2012-09-06 10:57obilodeauStatusresolved => closed

Notes
(0002883)
obilodeau   
2012-08-06 16:33   
One could always override the default value in the template itself so I agree that it should be removed.

Did you git blame and try to find why there's support for one that is specified or not? If there's no good explicit reason, go ahead or assign the task to me.
(0002933)
obilodeau   
2012-08-15 10:33   
I'm going to fix this while I fix 0001302.
(0002934)
obilodeau   
2012-08-15 11:11   
Fixed in branch fix/apache-acl-generation-for-guests. Targeted for next stable release.
(0003019)
obilodeau   
2012-09-06 10:57   
fix released in 3.5.1 yesterday