PacketFence - BTS - PacketFence
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001298PacketFencecorepublic2011-10-04 11:522011-10-24 20:28
Reporterobilodeau 
Assigned Todwuelfrath 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version3.0.2Fixed in Version3.0.2 
fixed in git revision
fixed in mtn revision590bcc7d66ab7c4e96f3dce5057db8356822bfa0
Summary0001298: nodes are not unregistered on unregdate unless an expire mode is activated
DescriptionI was sure it was already filed but apparently it is not.

It's a major annoyance especially with the new guest management features but the fix will change default behavior so we need to document in UPGRADE and provide a flag to disable.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files? node.pm (2,053) 2011-10-05 16:25
https://www.packetfence.org/bugs/file_download.php?file_id=106&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-10-04 11:52obilodeauNew Issue
2011-10-04 11:52obilodeauStatusnew => assigned
2011-10-04 11:52obilodeauAssigned To => obilodeau
2011-10-05 16:25dwuelfrathNote Added: 0002316
2011-10-05 16:25dwuelfrathFile Added: node.pm
2011-10-05 16:26dwuelfrathNote Edited: 0002316
2011-10-06 10:00obilodeauAssigned Toobilodeau => dwuelfrath
2011-10-06 10:00obilodeauNote Added: 0002320
2011-10-07 09:06dwuelfrathNote Added: 0002329
2011-10-07 09:14dwuelfrathmtn revision => 590bcc7d66ab7c4e96f3dce5057db8356822bfa0
2011-10-07 09:14dwuelfrathStatusassigned => resolved
2011-10-07 09:14dwuelfrathResolutionopen => fixed
2011-10-07 09:14dwuelfrathFixed in Version => 3.0.1
2011-10-24 20:27obilodeauFixed in Version3.0.1 => 3.0.2
2011-10-24 20:27obilodeauNote Added: 0002393
2011-10-24 20:28obilodeauStatusresolved => closed
2011-10-24 20:28obilodeauTarget Version+1 => 3.0.2

Notes
(0002316)
dwuelfrath   
2011-10-05 16:25   
(edited on: 2011-10-05 16:26)
possible solution:

- add a flag in pf.conf which is enabled by default: registration.nodes_expire

- apply the attached patch (node.pm)
(0002320)
obilodeau   
2011-10-06 10:00   
So far so good, continue in that direction.

To improve:
- I don't like nodes_expire under [registration].. We should brainstorm about something better.

Missing:
- UPGRADE entry
- pf.conf.defaults entry
- documentation.conf entry
- NEWS entry

Submit an updated patch please.
(0002329)
dwuelfrath   
2011-10-07 09:06   
We decide not to add a flag for enabling / disabling the check for expired nodes.

The decision is based on the fact that if a node shouldn't be unregistered, an unreg date shouldn't be set.
(0002393)
obilodeau   
2011-10-24 20:27   
fix released in 3.0.2