PacketFence - BTS - PacketFence
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001063PacketFenceerror-handlingpublic2010-09-08 14:002011-01-26 15:38
Reporterobilodeau 
Assigned Toobilodeau 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version1.9.1Fixed in Version1.9.1 
fixed in git revision
fixed in mtn revisionb33aca6dd8c5188ffa51b23b8d87c7985312b126
Summary0001063: warnings in logs for pf::vlan line 100
DescriptionI think it's caused when we print the category name for a node if it's category is empty (meaning $category is undef).

I'm guessing very easy to fix.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-09-08 14:00obilodeauNew Issue
2010-09-08 14:02obilodeauNote Added: 0001641
2010-09-15 14:24obilodeauReproducibilityhave not tried => always
2010-09-15 14:24obilodeauStatusnew => assigned
2010-09-15 14:49obilodeauNote Added: 0001666
2010-09-15 14:50obilodeauNote Added: 0001667
2010-09-15 14:50obilodeauNote Edited: 0001666
2010-09-15 15:01obilodeauNote Added: 0001668
2010-09-15 15:04obilodeaumtn revision => b33aca6dd8c5188ffa51b23b8d87c7985312b126
2010-09-15 15:04obilodeauNote Added: 0001669
2010-09-15 15:04obilodeauStatusassigned => resolved
2010-09-15 15:04obilodeauFixed in Version => 1.9.1
2010-09-15 15:04obilodeauResolutionopen => fixed
2010-09-15 15:04obilodeauAssigned To => obilodeau
2011-01-26 15:38obilodeauStatusresolved => closed

Notes
(0001641)
obilodeau   
2010-09-08 14:02   
thinking about it, maybe the database schema hasn't been updated where I saw that.. I'll need to doubecheck.
(0001666)
obilodeau   
2010-09-15 14:49   
(edited on: 2010-09-15 14:50)
forget my above comment, it is a legitimate problem
(0001667)
obilodeau   
2010-09-15 14:50   
Instead of testing for undef on each access, I decided to modify the SQL so that category would be '' instead of undef. This is more consistent with the rest of pf::node's fields.
(0001668)
obilodeau   
2010-09-15 15:01   
I validated that this change had no adverse effect on node_modify's operations.
(0001669)
obilodeau   
2010-09-15 15:04   
problem fixed in 1.9 branch