PacketFence - BTS - PacketFence 1.7
I found what IMHO was some convoluted code in pf/bin/pfcmd, pf/bin/start and pf/bin/stop.
The "control" function code is identical in each of these three files.
The main issue I have is that the "control" function code doesn't do anything in terms of saving or restoring iptables when "control" receives the "restart" command. I also think that even when it does decide whether to do a "save_iptables" or a "restore_iptables" it does an inefficient job of it.
I believe that when a "restart" command is sent to "control" function the function should effectively call itself again with a "stop" command and then again with a "start" command. This way we can have a full restart that includes restarting iptables.
I also think it is important to move the restore_iptables test after the call to "service_ctl" since that way we can know for sure whether any services are still running before we restore_iptables.
I know it may be a long shot but I have attached a rewrite of the code for the "control" function that belongs in pf/bin/pfcmd, pf/bin/start and pf/bin/stop.
PFCMD_Control_Function.txt (1,403) 2008-05-28 15:16https://www.packetfence.org/bugs/file_download.php?file_id=35&type=bug